[BB-9706] fix: ensure certificate has a modified_date #784
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaustavb12
approved these changes
May 23, 2025
Member
kaustavb12
left a comment
kaustavb12
left a comment
There was a problem hiding this comment.
👍
- I tested this: Tested in the sandbox that certificate preview is working without a course end date.
- I read through the code
- I checked for accessibility issues
- Includes documentation
- I made sure any change in configuration variables is reflected in the corresponding client's
configuration-securerepository.
…eal certificates (openedx#36471) * fix: make the issued date displayed on previewed certificates match real certificates This PR fixes an inconsistency in the dates displayed on certificates previewed via Studio with "real" certificates rendered to users.
viadanna
force-pushed
the
viadanna/fix-certificate-date
branch
from
fc4a553 to
c0f047f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The change in this PR ensures the certificate generated in preview always has a modified date, even when the course has no end date. This is necessary to ensure the certificate is rendered correctly.
Copilot Summary
This pull request includes a small update to the
_get_user_certificatefunction inlms/djangoapps/certificates/views/webview.py. The change ensures that themodified_datefield defaults to the current date if no value is provided.Supporting information
Testing instructions
Deadline
ASAP